fix: remove local implementation of PayloadS3Pointer.java and use payloadoffloading-common#851
Merged
pankajagrawal16 merged 2 commits intomasterfrom Apr 28, 2022
Merged
fix: remove local implementation of PayloadS3Pointer.java and use payloadoffloading-common#851pankajagrawal16 merged 2 commits intomasterfrom
pankajagrawal16 merged 2 commits intomasterfrom
Conversation
…loadoffloading-common
jeromevdl
approved these changes
Apr 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #835
Description of changes:
removing dependency of payloadoffloading-common was accepted as a risk before as part of this discussion.
Since its fairly common for consumer apps to also depend upon payloadoffloading-common lib, this creates class path conflicts and hence we avoid having local implementation for now.
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.